nvme-print-json: delete nvme list verbose v1 version output#2990
nvme-print-json: delete nvme list verbose v1 version output#2990igaw merged 1 commit intolinux-nvme:masterfrom
Conversation
41c026a to
616159f
Compare
|
Just rebased with the master. |
|
I would like to keep the version output around because when we remove it, we will break existing users without any need. The v1 code doesn't hurt at this moment. Would I suggest is that we can change the default version. In this case we give the users the possibility to still use the older versions but they have to select it active. And with this we might convince them to update their code around nvme-cli output. |
|
Yes good idea so will change the default version to two for now. Thank you. |
To update nvme-cli output version 2 only in future. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
616159f to
adf7f67
Compare
|
Just updated the patch to change the default output format version to 2. |
|
Okay, let's try this. Since this is a breaking change we need to document on release. Need to write it somewhere down. Thanks! |
|
Just created the PR: #3222 to describe the change by the documentation. |
This is to output the version 2 output only.