Skip to content

types: Live Migration#913

Merged
igaw merged 1 commit intolinux-nvme:masterfrom
NateThornton:lm_types
Dec 6, 2024
Merged

types: Live Migration#913
igaw merged 1 commit intolinux-nvme:masterfrom
NateThornton:lm_types

Conversation

@NateThornton
Copy link
Copy Markdown
Contributor

Continues efforts from the newly minted TP4159 PCIe Infrastructure for Live Migration specification by adding additional types.

@NateThornton NateThornton marked this pull request as draft November 14, 2024 14:30
@NateThornton NateThornton force-pushed the lm_types branch 3 times, most recently from 300f72e to 4a2effd Compare November 14, 2024 14:45
@NateThornton NateThornton marked this pull request as ready for review November 14, 2024 14:49
Comment thread src/nvme/types.h Outdated
Comment thread src/nvme/types.h Outdated
Comment thread src/nvme/types.h Outdated
Comment thread src/nvme/types.h Outdated
Comment thread src/nvme/types.h Outdated
Comment thread src/nvme/types.h Outdated
Comment thread src/nvme/types.h Outdated
Comment thread src/nvme/types.h Outdated
Comment thread src/nvme/types.h
Comment thread src/nvme/types.h Outdated
Comment thread src/nvme/types.h Outdated
Comment thread src/nvme/types.h Outdated
Comment thread src/nvme/types.h
Comment thread src/nvme/types.h Outdated
@NateThornton
Copy link
Copy Markdown
Contributor Author

Comments reviewed - thanks for detailed scrutiny. I hope to have the changes ready by end of week. Will resolve with #916 too.

@igaw
Copy link
Copy Markdown
Collaborator

igaw commented Dec 3, 2024

Thanks a lot. Yeah, I went down the rabbit hole :)

@NateThornton NateThornton force-pushed the lm_types branch 3 times, most recently from f2da12d to 0aedaba Compare December 3, 2024 16:15
Continues efforts from the newly minted TP4159 PCIe Infrastructure for
Live Migration specification by adding additional types.

Signed-off-by: Nate Thornton <n.thornton@samsung.com>
@igaw
Copy link
Copy Markdown
Collaborator

igaw commented Dec 5, 2024

Sorry for the late response... (insert my usual busy excuse...)

@NateThornton NateThornton force-pushed the lm_types branch 2 times, most recently from 53d7cef to 3c2aeaf Compare December 5, 2024 15:58
@NateThornton
Copy link
Copy Markdown
Contributor Author

Incorporated all feedback & tidied up a few items. Hopefully this is it 🤞

@igaw igaw merged commit 0460e17 into linux-nvme:master Dec 6, 2024
@igaw
Copy link
Copy Markdown
Collaborator

igaw commented Dec 6, 2024

Looks good. Sorry that I enforce these rules on the API. I am more relaxed when it comes to the implementation but APIs tend to be PITA if we get them wrong (e.g. see the struct args stuff... something for 2.0) Anyway, thanks for the patience.

@NateThornton NateThornton deleted the lm_types branch December 6, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants