mi-mctp: Fix compile error for test/mi-mctp.c when !HAVE_LINUX_MCTP_H #1075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chorkin
force-pushed
the
user/chorkin/fix_errors_header
branch
2 times, most recently
from
182fa03 to
39699bc
Compare
chorkin
changed the title
chorkin
force-pushed
the
user/chorkin/fix_errors_header
branch
5 times, most recently
from
5db4c06 to
295723f
Compare
Contributor
Author
|
@jk-ozlabs can you have a peek at this? |
Collaborator
|
The change looks good, I'd just suggest a different naming for the new header file. The top-level Perhaps |
The test/mi-mctp.c fails to compile in certain cases where HAVE_LINUX_MCTP_H is false. There's a workaround for this condition in src/mi-mctp.c but not here. This change makes a common header and includes it in both cases. Signed-off-by: Chuck Horkin <chorkin@microsoft.com>
chorkin
force-pushed
the
user/chorkin/fix_errors_header
branch
from
295723f to
9b54eff
Compare
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when building the project on systems that don't support the <linux/mctp.h> header file.