Skip to content

Conversation

@ykaire-qti
Copy link
Contributor

Added a 10-second reset delay after flashing to improve stability on RB3 and IQ9 platforms

Signed-off-by: Yvonne Kaire ykaire@qti.qualcomm.com

firehose: Increase reset delay after flashing
Added a 10-second reset delay after flashing to improve stability on RB3 and IQ9 platforms

Signed-off-by: Yvonne Kaire <ykaire@qti.qualcomm.com>
@JohnSagaQuic
Copy link

  1. The 10-second delay occurs after flashing the image and before rebooting the device. Through extensive trial and error, we discovered that without a 5–7 second delay, the device may hang and require a full power cycle (disconnect and reconnect the power supply). To be safe, we implemented a 10-second delay for Rb3, IQ9.
  2. PCAT also uses the same 10-second delay for the same stability reasons

@quic-bjorande
Copy link
Contributor

The problem description is too vague, and the fix merely put band aid on a symptom. Please help derive a proper description of the problem.

Also, there's a stray "Update firehose.c" at the beginning of the commit message.

@JohnSagaQuic
Copy link

Bjorn,
We received quantitative results from the testing team:

Using the same setup, they compared two builds:

QDL 2.4
QDL 2.4 with this PR applied

With QDL 2.4, there were 18 failures out of 30 flash attempts across Rubik Pi, IQ8, and IQ9 platforms.
After applying the patch (including the fix from this PR), all 30 test runs passed.

According to the CoreBSP team, the same 10‑second delay has existed in fh_loader and PCAT from the beginning.

@quic-bjorande
Copy link
Contributor

Thank you for the updated data @JohnSagaQuic.

You answer clarifies the size of the problem, but not what the problem is. The statement is still that the change will "improve stability".

Also, the motivation needs to go in the commit message of the change - so that it's captured in the git history once merged. So @ykaire-qti please incorporate these changes - and please resolve the buildtest issues reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants