block/partitions/ldm: fix TOCBLOCK bitmap mismatch message argument order#893
Open
blktests-ci[bot] wants to merge 1 commit into
Open
block/partitions/ldm: fix TOCBLOCK bitmap mismatch message argument order#893blktests-ci[bot] wants to merge 1 commit into
blktests-ci[bot] wants to merge 1 commit into
Conversation
…rder The ldm_crit() calls in ldm_parse_tocblock() have the format string arguments in the wrong order. The format string reads: "TOCBLOCK's first bitmap is '%s', should be '%s'." The intent is to print the actual (on-disk) name first and the expected name second. However, the constant TOC_BITMAP1/TOC_BITMAP2 (expected) is passed as the first argument and toc->bitmapX_name (actual) as the second, producing misleading diagnostic output on corrupt disks. Swap the two arguments so the printed message matches its intended semantics. Signed-off-by: liyouhong <liyouhong@kylinos.cn>
Author
|
Upstream branch: e8c2f9f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: block/partitions/ldm: fix TOCBLOCK bitmap mismatch message argument order
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1101426