floppy: force media-change checks when clearing events#800
Open
blktests-ci[bot] wants to merge 2 commits into
Open
floppy: force media-change checks when clearing events#800blktests-ci[bot] wants to merge 2 commits into
blktests-ci[bot] wants to merge 2 commits into
Conversation
Author
|
Upstream branch: 6d35786 |
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
1f0d33a to
b1870f6
Compare
Author
|
Upstream branch: aa54b1d |
blktests-ci
Bot
force-pushed
the
series/1090195=>linus-master
branch
from
fa43a1d to
dd20c5c
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
b1870f6 to
ca57796
Compare
Author
|
Upstream branch: 70eda68 |
blktests-ci
Bot
force-pushed
the
series/1090195=>linus-master
branch
from
dd20c5c to
8cc9d38
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
ca57796 to
c1feb59
Compare
Author
|
Upstream branch: 8bc67e4 |
blktests-ci
Bot
force-pushed
the
series/1090195=>linus-master
branch
from
8cc9d38 to
d2b0e65
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
c1feb59 to
ea833a1
Compare
Author
|
Upstream branch: 6779b50 |
blktests-ci
Bot
force-pushed
the
series/1090195=>linus-master
branch
from
d2b0e65 to
75297b9
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
ea833a1 to
7af85d1
Compare
floppy_open() tries to make blocking read/write opens perform a fresh media-change check by clearing drive_state[drive].last_checked before calling disk_check_media_change(). That timestamp is also updated by disk_change() when another FDC operation observes that the disk-change line is clear. The worker path that calls disk_change() is not serialized by the floppy_mutex/open_lock pair held by floppy_open(). A worker can therefore store a recent jiffies value after floppy_open() stores zero and before the synchronous disk_check_media_change() call reaches floppy_check_events(). The checkfreq throttle can then treat the media-change state as fresh and skip the hardware poll that the open path explicitly tried to force. Use the block layer's clearing mask instead of a racy timestamp sentinel. When DISK_EVENT_MEDIA_CHANGE is being synchronously cleared, bypass the checkfreq throttle and poll the drive. Periodic event checks still use last_checked to avoid unnecessary polling, and floppy_open() no longer needs to write last_checked itself. Signed-off-by: Cen Zhang <zzzccc427@gmail.com>
Author
|
Upstream branch: 79bd2dd |
blktests-ci
Bot
force-pushed
the
series/1090195=>linus-master
branch
from
75297b9 to
e7d37e0
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
7af85d1 to
de94ac7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: floppy: force media-change checks when clearing events
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1090195