Add charge mode setting for batteries #849
Open
+49
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will try and set the charge type for all batteries detected Signed-off-by: Sven Willett <sven.willett@gmail.com>
Signed-off-by: Sven Willett <sven.willett@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the CHARGE_MODE setting that can be set to different options depending on your system.
On my Lenovo Legion, I can set it to Long_Life in order to limit the battery to 80% maximum charge. This uses the new charge_types property of the sysfs power supply class. This is equivalent to the old conservation_mode property, but has support for other hardware as well, such as with Dell or HP, although options may be different.
Not sure if I did everything correctly, but I think this a useful setting that I would like to see in TLP. I ran make checkall to check for any code issues, and did some testing on my system.