Skip to content

Conversation

@mpolotsk-akamai
Copy link
Contributor

@mpolotsk-akamai mpolotsk-akamai commented Feb 2, 2026

Description 📝

This PR fixes pagination in Users Table when the last user on a page is removed.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Navigate to the previous page to avoid showing an empty table
  • Fixed empty table styling issue
  • UX copy updates

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Preview 📷

Before After
Screen.Recording.2026-02-02.at.11.54.09.AM.mov
Screen.Recording.2026-02-02.at.11.52.20.AM.mov

How to test 🧪

Prerequisites

(How to setup test environment)

  • use IAM Parent/Child account with mock data

Verification steps

(How to verify changes)

  • Go to /iam/users with 26 (or more) users.
  • Go to the last page of the table.
  • Click "Delete User" from the User Actions menu and delete one or more users until the last page becomes empty.
  • Verify that the table navigates to the previous page.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@abailly-akamai
Copy link
Contributor

@mpolotsk-akamai can you see if #13346 fixes your use case as well?

@aaleksee-akamai
Copy link
Contributor

@mpolotsk-akamai can you see if #13346 fixes your use case as well?

@abailly-akamai but here is server-side pagination, and the table wasn’t updated after the data changed. So something is off with it

@mpolotsk-akamai
Copy link
Contributor Author

@mpolotsk-akamai can you see if #13346 fixes your use case as well?

@abailly-akamai , this change doesn’t fix my case.

@mpolotsk-akamai mpolotsk-akamai force-pushed the UIE-10093-users-table-previous-page branch from 4f1310e to a147f0a Compare February 2, 2026 14:07
@mpolotsk-akamai mpolotsk-akamai changed the title fix: [UIE-10093] - IAM Users Table: Fix pagination when the last user on a page is removed fix: [UIE-10093], [UIE-10139] - IAM Users Table: Fix pagination when the last user on a page is removed, UX copy updates Feb 2, 2026
@abailly-akamai
Copy link
Contributor

@aaleksee-akamai @mpolotsk-akamai yes, sorry we are dealing with server side pagination.

I find it surprising to have to do this. I wonder if this is always the case or if this is isolated with this particular case. Cause we would also want to try to fix it as the hook level if this is a general problem

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works - perhaps we can work on a more holistic solution in the future. Those are still edge case so it's not a big priority to spend much time on it. thx!

<Table aria-label="List of Users" sx={{ tableLayout: 'fixed' }}>
<UsersLandingTableHead order={order} />
<UsersLandingTableHead
isChildWithDelegationEnabled={isChildWithDelegationEnabled}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I remember correctly, @abailly-akamai is not a big fan of passing down boolean props, and we had this discussion when I implemented that logic for this table

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaleksee-akamai , I reverted that change 🙂

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Feb 4, 2026
@mpolotsk-akamai mpolotsk-akamai force-pushed the UIE-10093-users-table-previous-page branch from 1662014 to 4e0de2d Compare February 5, 2026 14:32
@mpolotsk-akamai mpolotsk-akamai force-pushed the UIE-10093-users-table-previous-page branch from 4e0de2d to 98d8d6c Compare February 5, 2026 14:44
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #7 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing865 Passing11 Skipped39m 15s

Details

Failing Tests
SpecTest
quotas-storage.spec.tsCloud Manager Cypress Tests→Quota workflow tests→Quota storage table » Quotas and quota usages display properly

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/account/quotas-storage.spec.ts"

@mpolotsk-akamai mpolotsk-akamai merged commit 98effff into linode:develop Feb 5, 2026
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IAM Delegation Implementing the new Parent/Child delegation UI IAM (Identity & Access Management)

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

4 participants