feat: [UIE-10074, UIE-10076, UIE-10075] - IAM: bugs resetting to prev page#13330
Closed
aaleksee-akamai wants to merge 5 commits intolinode:developfrom
Closed
feat: [UIE-10074, UIE-10076, UIE-10075] - IAM: bugs resetting to prev page#13330aaleksee-akamai wants to merge 5 commits intolinode:developfrom
aaleksee-akamai wants to merge 5 commits intolinode:developfrom
Conversation
aaleksee-akamai
commented
Jan 28, 2026
| // Check if the change decreased the total roles by exactly one. | ||
| // This occurs when switching to a role the user already had, | ||
| // causing the two roles to merge into a single entry. | ||
| const decreasedByOne = |
Contributor
Author
There was a problem hiding this comment.
why we need it:
user has linode_admin and linode_viewer. Change role action can result in 2 different outcomes:
- change role to a new one
ex: changing fromlinode_viewertolinode_contributor
The total number of roles does not change (one role is replaced by another) - change role to an existing one
ex: changing fromlinode_viewertolinode_admin(when the user already haslinode_admin)
The total number of roles decreases by one, because two roles are merged into a single role entry
So we should reset to the previous page only when the total number of roles decreases
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/create-linode-with-add-ons.spec.ts" |
|||||||||||||||||
25 tasks
Contributor
|
@aaleksee-akamai i came up with what I think is a much cleaner approach: #13346 please let me know what you think. If we go with it we should consider updating |
Contributor
|
as an alternative consideration, see #13346 which fixes those issues at the root (hook) |
Contributor
Author
|
I prefer to go ahead with your approach! I'll close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR fixes couple of bugs related to resetting page in Assigned Roles/Entities table when user Remove/Unassign/Change role/Assignment
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
Screen.Recording.2026-01-28.at.10.12.03.AM.mov
Screen.Recording.2026-01-28.at.10.13.25.AM.mov
Screen.Recording.2026-01-28.at.10.22.19.AM.mov
Screen.Recording.2026-01-28.at.10.23.27.AM.mov
Screen.Recording.2026-01-28.at.10.24.48.AM.mov
Screen.Recording.2026-01-28.at.10.25.44.AM.mov
Screen.Recording.2026-01-28.at.10.40.11.AM.mov
Screen.Recording.2026-01-28.at.10.41.03.AM.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
UIE-10074
UIE-10075 - 1st issue
linode_adminrole is the last one on the 1st page andlinode_contributeris the 1st role on the 2nd pagelinode_contributertolinode_viewerUIE-10075 - 2nd issue
UIE-10076
Verification steps
(How to verify changes)
UIE-10074
UIE-10075
UIE-10076
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅