Skip to content

Support Linode Integrations with ACLP Alerts#879

Merged
yec-akamai merged 5 commits intoproj/aclp-linode-alertsfrom
TPT-2923/linode-aclp-alert
Feb 10, 2026
Merged

Support Linode Integrations with ACLP Alerts#879
yec-akamai merged 5 commits intoproj/aclp-linode-alertsfrom
TPT-2923/linode-aclp-alert

Conversation

@yec-akamai
Copy link
Contributor

📝 Description

Add ACLP alerts support to linode instance operations.

✔️ How to Test

make test-unit

@yec-akamai yec-akamai requested a review from a team as a code owner January 23, 2026 17:27
@yec-akamai yec-akamai requested review from Copilot and psnoch-akamai and removed request for a team January 23, 2026 17:27
@yec-akamai yec-akamai added the new-feature for new features in the changelog. label Jan 23, 2026
@yec-akamai yec-akamai requested a review from vshanthe January 23, 2026 17:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for ACLP (Access Control List Policy) alerts to Linode instance operations, enabling system and user alert configurations during instance creation, updates, and cloning.

Changes:

  • Extended InstanceAlert struct to include SystemAlerts and UserAlerts fields
  • Added InstanceACLPAlertsOptions type for configuring alerts during instance creation and cloning
  • Updated instance operation options (InstanceCreateOptions, InstanceUpdateOptions, InstanceCloneOptions) to support alert configuration
  • Added comprehensive test coverage for alert functionality across Get, Create, Update, and Clone operations

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
instances.go Added ACLP alert fields to InstanceAlert struct and new InstanceACLPAlertsOptions type for alert configuration in create/clone operations
test/unit/instance_test.go Added test assertions to verify SystemAlerts and UserAlerts are properly handled in Get, Create, Update, and Clone operations
test/unit/fixtures/instance_get.json Added alerts field with system_alerts and user_alerts arrays to mock response data
test/unit/fixtures/instance_create.json Added alerts field with system_alerts and user_alerts arrays to mock response data
test/unit/fixtures/instance_update.json Added alerts field with system_alerts and user_alerts arrays to mock response data
test/unit/fixtures/instance_clone.json Added alerts field with system_alerts and user_alerts arrays to mock response data

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@vshanthe vshanthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tests Passing

@yec-akamai yec-akamai merged commit 1325f81 into proj/aclp-linode-alerts Feb 10, 2026
10 checks passed
@yec-akamai yec-akamai deleted the TPT-2923/linode-aclp-alert branch February 10, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature for new features in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants