Bugfix: VPC api call failures could cause deletion of all nodes#570
Open
akaokunc wants to merge 1 commit into
Open
Bugfix: VPC api call failures could cause deletion of all nodes#570akaokunc wants to merge 1 commit into
akaokunc wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I was trying find a bug in cooperation between linode LKE api provider and linode CCM to explain unexpected behavior which I have seen on few clusters. I'm not sure I found the root cause of the issue I was observing, but I do believe I have found at least related one.
Here's the possible failure chain:
InstanceExists returns false, nil for every node, because linodeByID finds nothing in the empty cache and returns cloudprovider.InstanceNotFound which InstanceExists converts to false, nil.
The cache is written with an empty map and
lastUpdateis stampednc.nodes = newNodes; nc.lastUpdate = time.Now(), so the bad data persists for the full TTL period (default 15s).The K8s node lifecycle controller deletes such nodes.
General:
Pull Request Guidelines: