Parse OBJ endpoint domain dynamically #851
Open
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezilber-akamai
requested review from
vshanthe and
zliang-akamai
and removed request for
a team
ezilber-akamai
added
the
improvement
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the OBJ plugin to work with non-production Linode environments by dynamically resolving OBJ endpoint domains from the LINODE_CLI_API_HOST environment variable instead of using hardcoded production domains.
Changes:
- Extracts environment subdomain from
LINODE_CLI_API_HOSTto construct appropriate OBJ domains - Updates
BASE_URL_TEMPLATEandBASE_WEBSITE_TEMPLATEto use dynamically resolved domains - Adds regex pattern matching to parse the API host and derive the corresponding OBJ domain
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ezilber-akamai
force-pushed
the
TPT-3949-resolve-obj-endpoints-dynamically
branch
from
da05cae to
07395a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Enables using OBJ plugin with non-production environments by resolving OBJ endpoints dynamically from the
LINODE_CLI_API_HOSTenvironment variable, which configures the environment that the CLI is pointing at.✔️ How to Test
Pointing at a non-production environment (i.e. DevCloud), attempt to run various OBJ plugin CLI commands