Skip to content

fix: backup gitea when gitea not enabled#802

Open
dennisvankekem wants to merge 1 commit into
mainfrom
APL-1890
Open

fix: backup gitea when gitea not enabled#802
dennisvankekem wants to merge 1 commit into
mainfrom
APL-1890

Conversation

@dennisvankekem

Copy link
Copy Markdown
Collaborator

Considerations

  • I have tested the changes in both light and dark mode.
  • I have considered the need for new unit tests.
  • I have tested the changes on a cluster.
  • I have included relevant documentation updates.
  • I have an approved Figma design or have reflected my changes in Figma
  • I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
  • I have tested the changes for responsiveness in different screen resolutions.
  • I have tested expected error states and verified that the user is presented with informative error messages.
  • I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

break
case 'platformBackups':
if (!appsEnabled.harbor) set(schema, 'properties.database.properties.harbor.readOnly', true)
if (!appsEnabled.gitea) set(schema, 'properties.gitea.readOnly', true)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but since Gitea has both an application and a database backup, I think both would need to be read only if Gitea is not enabled.

Suggested change
if (!appsEnabled.gitea) set(schema, 'properties.gitea.readOnly', true)
if (!appsEnabled.gitea) {
  set(schema, 'properties.database.properties.gitea.readOnly', true)
set(schema, 'properties.gitea.readOnly', true)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants