Change simd_from argument order to match other methods#180
Merged
valadaptive merged 2 commits intolinebender:mainfrom Dec 20, 2025
Merged
Change simd_from argument order to match other methods#180valadaptive merged 2 commits intolinebender:mainfrom
simd_from argument order to match other methods#180valadaptive merged 2 commits intolinebender:mainfrom
Conversation
valadaptive
force-pushed
the
simd-from-order
branch
from
34f0c8b to
5728e50
Compare
LaurenzV
approved these changes
Dec 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #153.
As noted in that issue, the
simd_frommethod currently takes the SIMD token as the second argument. Thefrom_[...]methods onSimdBase, on the other hand, take it as the first argument.This PR changes the
simd_fromsignature to take the SIMD token as the first argument for consistency.One downside is that this is now backwards from
simd_into, which has to take the token as the second argument since the first one must beself. I think most people will be callingsimd_intoin method form instead of explicitly passingself, so I don't think that's a huge issue.