feat: updating stainless.yml to remove base external account#211
Open
feat: updating stainless.yml to remove base external account#211
Conversation
Contributor
Greptile SummaryThis PR adds a new OpenAPI schema transformation to the Stainless configuration that removes Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| .stainless/stainless.yml | Adds transformation to remove $ref from allOf[0] in 16 ExternalAccountInfo schemas to fix type conflicts during schema merging |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[OpenAPI Schema] --> B{Stainless Transformations}
B --> C[Remove customerType from fields]
B --> D[Remove accountType from base schemas]
B --> E[Remove sourceType from variants]
B --> F[Remove destinationType from variants]
B --> G[NEW: Remove BaseExternalAccountInfo $ref]
G --> H[UsAccountExternalAccountInfo]
G --> I[IbanAccountExternalAccountInfo]
G --> J[PixAccountExternalAccountInfo]
G --> K[Crypto Wallet Schemas]
G --> L[12 other account types]
H --> M[Client Code Generation]
I --> M
J --> M
K --> M
L --> M
M --> N[Type-safe SDKs without conflicts]
Last reviewed commit: 8e33df3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Remove BaseExternalAccountInfo allOf reference from ExternalAccountInfo schemas to fix type conflicts.
What changed?
Added a new transformation in the Stainless configuration to remove the
$refkey from theallOf[0]property in multiple ExternalAccountInfo schemas. This affects 16 different account types including UsAccount, ClabeAccount, PixAccount, IbanAccount, and various wallet types.How to test?
Why make this change?
The BaseExternalAccountInfo allOf references were causing type conflicts when the allOf operation merged them with the base schema. This change prevents these conflicts by removing the problematic references, resulting in more consistent and accurate type definitions.