Skip to content

Splice fixes for chanmon_consistency fuzz target #4655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wpaulino wants to merge 2 commits into
base: main
Choose a base branch
from
+17 −5
Open

Splice fixes for chanmon_consistency fuzz target #4655

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1379144
Ignore stale splice signing fuzz events
wpaulino Jun 1, 2026
099bb09
Raise iteration capacity in chanmon consistency when settling state
wpaulino Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions fuzz/src/chanmon_consistency.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ use std::sync::atomic;
use std::sync::{Arc, Mutex};

const MAX_FEE: u32 = 10_000;
const MAX_SETTLE_ITERATIONS: usize = 256;

@TheBlueMatt TheBlueMatt Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow

struct FuzzEstimator {
ret_val: atomic::AtomicU32,
}
Expand Down Expand Up @@ -2814,9 +2815,20 @@ impl<'a, Out: Output + MaybeSend + MaybeSync> Harness<'a, Out> {
..
} => {
let signed_tx = nodes[node_idx].wallet.sign_tx(unsigned_transaction).unwrap();
nodes[node_idx]
.funding_transaction_signed(&channel_id, &counterparty_node_id, signed_tx)
.unwrap();
match nodes[node_idx].funding_transaction_signed(
&channel_id,
&counterparty_node_id,
signed_tx,
) {
Ok(()) => {},
Err(APIError::APIMisuseError { ref err })
if err.contains("not expecting funding signatures") =>
{
// A queued signing event can be invalidated by a later `tx_abort`
// before the application handles it.
},
Err(e) => panic!("{e:?}"),
}
},
events::Event::SpliceNegotiated { new_funding_txo, .. } => {
let mut txs = nodes[node_idx].broadcaster.txn_broadcasted.borrow_mut();
Expand Down Expand Up @@ -2854,9 +2866,9 @@ impl<'a, Out: Output + MaybeSend + MaybeSync> Harness<'a, Out> {
fn process_all_events(&mut self) {
let mut last_pass_no_updates = false;
for i in 0..std::usize::MAX {
if i == 100 {
if i == MAX_SETTLE_ITERATIONS {
panic!(
"It may take may iterations to settle the state, but it should not take forever"
"It may take many iterations to settle the state, but it should not take forever"
);
}
let mut made_progress = self.checkpoint_manager_persistences();
Expand Down