Expose inner ProbabilisticScorer accessors on CombinedScorer#4568
Expose inner ProbabilisticScorer accessors on CombinedScorer#4568tnull merged 1 commit intolightningdevkit:mainfrom
Conversation
|
I've assigned @valentinewallace as a reviewer! |
|
No trait method conflicts. The diff is small and straightforward — two read-only accessors returning shared references to private fields. Let me verify the doc link targets are correct (the referenced methods The No issues found. No issues found. This is a clean, minimal PR that adds two read-only accessor methods ( |
tnull
left a comment
There was a problem hiding this comment.
Ah, one comment post-merge: for the next time, please provide a better commit message, explaining the motivation and nature of the change. Please refer to https://cbea.ms/git-commit/ for guidance.
This PR adds public accessors to
CombinedScorerfor its innerProbabilisticScorers.Placed in a new
implblock without theG: Clone/L: Clonebounds required bynew/merge/set_scores, matching the bounds on the other&selfimpls.Motivation: while working on adding a probing service to ldk-node (lightningdevkit/ldk-node#815), I realized that it is useful to have scorer's internal liquidity estimates to evaluate the performance of a particular probing strategy.
Right now it is done via an ugly workaround of serializing and de-serializing the scorer to reach
estimated_channel_liquidity_rangeand this PR aims to fix that.It will be used in for further development of probing service, in strategy efficiency ranking.