Avoid sending stfu for quiescent splice action while pending splice#4426
Merged
wpaulino merged 1 commit intolightningdevkit:mainfrom Feb 19, 2026
Merged
Conversation
We can't splice while one is already pending, so there's no point in attempting to become quiescent.
|
👋 Thanks for assigning @jkczyz as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4426 +/- ##
=======================================
Coverage 85.90% 85.91%
=======================================
Files 156 156
Lines 103965 103972 +7
Branches 103965 103972 +7
=======================================
+ Hits 89316 89326 +10
Misses 12128 12128
+ Partials 2521 2518 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jkczyz
approved these changes
Feb 19, 2026
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Contributor
Author
|
Merging with one approval since this is trivial |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't splice while one is already pending, so there's no point in attempting to become quiescent.
Found by the
chanmon_consistencyfuzzer.