Remove test util macros#4425
Conversation
|
I've assigned @wpaulino as a reviewer! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4425 +/- ##
=======================================
Coverage 85.90% 85.90%
=======================================
Files 156 156
Lines 103990 103983 -7
Branches 103990 103983 -7
=======================================
- Hits 89333 89327 -6
Misses 12135 12135
+ Partials 2522 2521 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| let reason = ClosureReason::HolderForceClosed { broadcasted_latest_txn: Some(true), message }; | ||
| check_closed_event(&nodes[0], 1, reason, &[node_b_id], 100000); | ||
| check_closed_broadcast!(nodes[0], true); | ||
| check_closed_broadcast(&nodes[0], 1, true).pop(); |
There was a problem hiding this comment.
Usually we don't call pop since we rely on the length assertion
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Removed some macros that could be replaced 1:1 with function calls by the same name.
check_closed_broadcastget_payment_preimage_hashget_closing_signed_broadcastDid this while trying out claude