Switch SplicePrototype feature flag to the prod feature bit#4387
Conversation
|
👋 Thanks for assigning @wpaulino as a reviewer! |
|
@TheBlueMatt this needs a rebase |
When we shipped 0.2 we used the feature bit 155 to signal splicing, in line with what eclair was using. However, eclair was actually using that bit to signal splicing on a previous design which is incompatible with the current spec. The result of this was that eclair nodes may attempt to splice using their protocol and we'd fail to deserialize their splice message (resulting in a reconnect, which luckily would clear their splice attempt and return the connection to normal). As we really need to get off of their feature bit and there's not much reason to keep using a non-final-spec bit, we simply redefine `SplicePrototype` to bit 63 here.
Now that `SplicePrototype` and `SpliceProduction` share the same feature bit, there's not really any reason to have the `SplicePrototype` feature at all. Instead, we drop it, leaving only a `Splice` feature.
TheBlueMatt
force-pushed
the
2026-02-stop-squatting-features
branch
from
2992536 to
5427b0d
Compare
|
Oops sorry I did this on 0.2, pushed against main. |
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4387 +/- ##
=======================================
Coverage 86.00% 86.01%
=======================================
Files 156 156
Lines 102857 102834 -23
Branches 102857 102834 -23
=======================================
- Hits 88465 88455 -10
+ Misses 11883 11871 -12
+ Partials 2509 2508 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Backported to 0.2 in #4389 |
4 participants
We need to backport the first commit to 0.2 to fix current compat issues.