Revert "Check semver of all workspace crates rather than an explicit …#4378
Revert "Check semver of all workspace crates rather than an explicit …#4378tnull wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
…list" This reverts commit a123cfa. In this commit we made a bunch of changes to our SemVer CI that switched away from the default CI runner, but also stopped testing particular features for sub-crates. Here we revert these changes as we still want to test explicit features individually *and* should just use the CI runner.
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4378 +/- ##
=======================================
Coverage 86.01% 86.01%
=======================================
Files 156 156
Lines 102857 102857
Branches 102857 102857
=======================================
+ Hits 88474 88477 +3
+ Misses 11876 11872 -4
- Partials 2507 2508 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
The previous crate list was missing a few crates (notably lightning-invoice, but its not our full crate list). If we're missing some features we should just add the missing features that we want to check explicitly.
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
|
If we want to improve the feature coverage beyond the current simple all/none, we should probably have some script that parses features and tests all the feature combos. |
That's inaccurate. It checked the entire workspace with default features, and then also checked a list of crates with specific feature sub-sets. So the only thing that might have been missed is to test
That was exactly the previous approach before you changed it? |
3 participants
…list"
This reverts commit a123cfa.
In this commit we made a bunch of changes to our SemVer CI that switched away from the default CI action, but also stopped testing particular features for sub-crates. Here we revert these changes as we still want to test explicit features individually and should just use the CI action.