Use --quiet not --verbose on cargo calls in ci-tests.sh#4368
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom Feb 3, 2026
Merged
Use --quiet not --verbose on cargo calls in ci-tests.sh#4368TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
--quiet not --verbose on cargo calls in ci-tests.sh#4368TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
Conversation
|
👋 I see @joostjager was un-assigned. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4368 +/- ##
==========================================
+ Coverage 85.98% 86.00% +0.02%
==========================================
Files 156 156
Lines 102641 102641
Branches 102641 102641
==========================================
+ Hits 88258 88281 +23
+ Misses 11873 11854 -19
+ Partials 2510 2506 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Might as well go all the way with |
I'm pretty confident I've never needed the full command strings printed by the `--verbose` argument to `cargo` in `ci-tests.sh` and it makes the output nontrivially larger. Further, I'm not sure there's really much reason at all to output which thing is built built - we only care about failures, thus we switch to `--quiet`. This should make CI output comparatively easy to parse as scrolling up to see which command failed requires a lot less scrolling.
TheBlueMatt
force-pushed
the
2026-02-quieter-ci
branch
from
f5c9cfe to
d2eeb0a
Compare
Collaborator
Author
|
Good point. Moved to |
TheBlueMatt
changed the title
--verbose arguments to cargo calls in ci-tests.sh--quiet not --verbose on cargo calls in ci-tests.sh
wpaulino
approved these changes
Feb 2, 2026
joostjager
approved these changes
Feb 3, 2026
Contributor
joostjager
left a comment
joostjager
left a comment
There was a problem hiding this comment.
This is a strict improvement. Not mutually exclusive with #4357 either
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm pretty confident I've never needed the full command strings printed by the
--verboseargument tocargoinci-tests.shand it makes the output nontrivially larger.