Remove spurious debug assertion added in 0.2 #4312
Conversation
|
👋 Thanks for assigning @wpaulino as a reviewer! |
TheBlueMatt
force-pushed
the
2026-01-spurious-debug-assertion
branch
from
873bee1 to
809a3f5
Compare
In 20877b3 we added a `debug_assert`ion to validate that if we call `maybe_free_holding_cell_htlcs` and it doesn't manage to generate a new commitment (implying `!can_generate_new_commitment()`) that we don't have any HTLCs to fail, but there was no reason for that, and its reachable. Here we simply remove the spurious debug assertion and add a test that exercises it.
TheBlueMatt
force-pushed
the
2026-01-spurious-debug-assertion
branch
from
809a3f5 to
b524b9b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4312 +/- ##
==========================================
- Coverage 86.59% 86.57% -0.02%
==========================================
Files 158 158
Lines 102368 102367 -1
Branches 102368 102367 -1
==========================================
- Hits 88641 88622 -19
- Misses 11313 11328 +15
- Partials 2414 2417 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wpaulino
left a comment
wpaulino
left a comment
There was a problem hiding this comment.
Landing with one approval given the change is trivial and has test coverage.
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
|
Backported in #4344 |
3 participants
In 20877b3 we added a
debug_assertion to validate that if we callmaybe_free_holding_cell_htlcsand it doesn't manage to generate a new commitment (implying!can_generate_new_commitment()) that we don't have any HTLCs to fail, but there was no reason for that, and its reachable.Here we simply remove the spurious debug assertion and add a test that exercises it.