Async signing test util follow ups#3151
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom Jul 8, 2024
Merged
Conversation
- Remove unused unavailable signers in TestKeysInterface - Remove unnecessary display implementation for SignerOp - Move set of test disabled signer ops to EnforcementState - Add method to enable/disable all signer ops at once
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3151 +/- ##
==========================================
- Coverage 89.81% 89.74% -0.07%
==========================================
Files 121 121
Lines 99314 99331 +17
Branches 99314 99331 +17
==========================================
- Hits 89195 89141 -54
- Misses 7514 7532 +18
- Partials 2605 2658 +53 ☔ View full report in Codecov by Sentry. |
TheBlueMatt
approved these changes
Jul 8, 2024
Collaborator
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
LGTM, its only test code so not bothering to wait for another review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some followups on #3115.