Log each condition that was violated for a stale monitor

[waterson]

There are several conditions that can be violated which indicate a stale monitor. This logs each that doesn't hold.

[TheBlueMatt]

I'm not 100% sure that any of these are reachable without also hitting the update_id check, but, sure.

[codecov-commenter]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (eb44d99) 90.61% compared to head (ff8c5db) 90.60%.
Report is 6 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2557      +/-   ##
==========================================
- Coverage   90.61%   90.60%   -0.01%     
==========================================
  Files         110      110              
  Lines       57573    57795     +222     
  Branches    57573    57795     +222     
==========================================
+ Hits        52167    52367     +200     
- Misses       5406     5428      +22     

Files Changed	Coverage Δ
lightning/src/ln/channelmanager.rs	87.20% <100.00%> (+0.02%)	⬆️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[waterson]

I'm not 100% sure that any of these are reachable without also hitting the update_id check, but, sure.

In the steady state, you're probably right, but it's actually how I figured out what was wrong with #2554. :)

[wpaulino]

LGTM