Skip to content

Change enum serialization to lowercase #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
randomlogin wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Change enum serialization to lowercase #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ldk-server-grpc/src/serde_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ use std::fmt::Write;
use serde::Serializer;

/// Generates a serde serializer that converts an `i32` proto enum field to its
/// string name via `from_i32()` and `as_str_name()`.
/// lowercased string name via `from_i32()` and `as_str_name()`.
macro_rules! stringify_enum_serializer {
($fn_name:ident, $enum_type:ty) => {
pub fn $fn_name<S>(value: &i32, serializer: S) -> Result<S::Ok, S::Error>
Expand All @@ -27,9 +27,9 @@ macro_rules! stringify_enum_serializer {
{
let name = match <$enum_type>::from_i32(*value) {
Some(v) => v.as_str_name(),
None => "UNKNOWN",
None => "unknown",
};
serializer.serialize_str(name)
serializer.serialize_str(&name.to_ascii_lowercase())
}
};
}
Expand Down