Refactoring binding python test#805
Refactoring binding python test#805heyolaniran wants to merge 8 commits intolightningdevkit:mainfrom
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
tnull
left a comment
There was a problem hiding this comment.
Hmm, honestly the only real change worth considering is the move to the event_handling method (though we'd want to rename it to something like expect_event).
I'm afraid everything else here looks like unnecessary code changes that don't really do anything substantially different and hence are not worth the churn.
|
I understand, thanks for the review. I'll be focused on the expect event function and try to make some improvments about some cases when a specific return is expected too. |
tnull
left a comment
There was a problem hiding this comment.
Okay, but there are still a lot of changes in this PR that aren't connected to the expect_event method transition. Please revert them for now.
|
thanks for various suggestions, the history of change is more clear and all the refactoring updates are focused around the various expected event handler.
|
Hello @tnull x @enigbe
In this Pull Request, I'd refactored the python binding test by introducing parallelism and by avoiding code duplication specially with event tracking and handling.
Thanks for having time to review the topic and send me a feedback if i need to make some specific action.