Fix NodeEntropy type mismatch in UniFFI builds #750
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapt the NodeEntropy initialization to account for diverging constructor signatures when the uniffi feature is active. The UniFFI layer requires shared ownership (Arc) and dynamic byte validation (Result/Vec) to facilitate memory management and error handling across the FFI boundary. This change ensures the builder receives the expected pointer type in UniFFI builds while maintaining the zero-cost stack allocation for standard Rust usage.
|
I've assigned @tnull as a reviewer! |
tnull
reviewed
Jan 11, 2026
Collaborator
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Ah, thanks, seems this slipped through.
One comment.
| builder_new.set_storage_dir_path(storage_path); | ||
| builder_new.set_chain_source_esplora(esplora_url, None); | ||
|
|
||
| let node_new = builder_new.build(node_entropy).unwrap(); |
Collaborator
There was a problem hiding this comment.
Ah, rather than adding extra cfg flags above, can we just follow the pattern we did elswhere and add an into() here?
Suggested change
| let node_new = builder_new.build(node_entropy.into()).unwrap(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In 06a8108,
persistence_backwards_compatibilitywas introduced. Currently, thefrom_seed_bytesconstructor and the subsequent build method have diverging signatures depending on whether theuniffifeature is enabled.Changes
This PR adjusts the integration tests to handle these signature differences:
NodeEntropystack allocation and fixed-size array input.Why this is necessary
UniFFI requires Arc wrappers for cross-language memory management. Without this change, the integration tests fail to compile when the
uniffifeature is active because the builder receives a raw struct instead of the expected shared pointer.