[Autofix][critical] Alert #2: Non-constant format string#61
Draft
xengine-qyt wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Copilot Autofix 自动修复报告
📋 基本信息
XEngine_Source/XEngine_ServiceApp/XEngine_HttpApp/XEngine_TaskGet/TaskGet_Oil.cpp第 14 行🔍 问题说明
Non-constant format string
The
printffunction, related functions likesprintfandfprintf, and other functions built atopvprintfall accept a format string as one of their arguments. When such format strings are literal constants, it is easy for the programmer (and static analysis tools) to verify that the format specifiers (such as%sand%02x) in the format string are compatible with the trailing arguments of the function call. When such format strings are not literal constants, it is more difficult to maintain the program: programmers (and static analysis tools) must perform non-local data-flow analysis to deduce what values the format string argument might take.Recommendation
If the argument passed as a format string is meant to be a plain string rather than a for
🤖 AI 修复思路
通用修复原则:凡是
printf/sprintf类函数,格式参数必须是常量字面量;如果只是想拷贝或拼接字符串,不要让外部数据位于“格式串”位置。本例最佳修复(不改变现有功能语义)是在
XEngine_Source/XEngine_ServiceApp/XEngine_HttpApp/XEngine_TaskGet/TaskGet_Oil.cpp第14行附近,把:_xstprintf(tszUrlBuffer, st_ServiceConfig.st_XApi.tszOilUrl, lpszCityStr);改为:
_xstprintf(tszUrlBuffer, _X("%s"), st_ServiceConfig.st_XApi.tszOilUrl);这样会把配置的 URL 作为普通字符串复制进
tszUrlBuffer,不再被当格式串解析,彻底消除该告警点。后续逻辑(URL 编码、HTTP 请求)保持不变。此改动不需要新增头文件、方法或第三方依赖。✅ Review 检查清单