Conversation
|
@james-d-mitchell this looks great, thanks! Tests failing is on me, just merged in fix. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
=======================================
Coverage ? 63.65%
=======================================
Files ? 9
Lines ? 399
Branches ? 0
=======================================
Hits ? 254
Misses ? 145
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
79f81ba to
7aba00d
Compare
jswent
left a comment
There was a problem hiding this comment.
there are a few cases where the vimscript creates refs to mutating functions without the !, so they point to dead links in the docs (404). I looked at it for a bit but I can't think of any good way to solve this with just vimscript
I think I caught all the cases but there could be some I missed
|
@james-d-mitchell I think I can write a lua script that would work with the mutating function convention, I'll give it a shot when I have some time |
Co-authored-by: Jake Swent <94636565+jswent@users.noreply.github.com>
|
@james-d-mitchell I think docs aren't building on this branch because of some issue with stale julia cache, just tested in another branch and it works fine. Can ignore that check. |
|
So merge? |
No description provided.