Skip to content

Comments

Runner doc#40

Merged
james-d-mitchell merged 7 commits intolibsemigroups:mainfrom
james-d-mitchell:runner-doc
Feb 21, 2026
Merged

Runner doc#40
james-d-mitchell merged 7 commits intolibsemigroups:mainfrom
james-d-mitchell:runner-doc

Conversation

@james-d-mitchell
Copy link
Member

No description provided.

@jswent
Copy link
Member

jswent commented Feb 20, 2026

@james-d-mitchell this looks great, thanks! Tests failing is on me, just merged in fix.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@2d9fe67). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/libsemigroups/runner.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage        ?   63.65%           
=======================================
  Files           ?        9           
  Lines           ?      399           
  Branches        ?        0           
=======================================
  Hits            ?      254           
  Misses          ?      145           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@james-d-mitchell james-d-mitchell added documentation Improvements or additions to documentation labels Feb 20, 2026
Copy link
Member

@jswent jswent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a few cases where the vimscript creates refs to mutating functions without the !, so they point to dead links in the docs (404). I looked at it for a bit but I can't think of any good way to solve this with just vimscript

I think I caught all the cases but there could be some I missed

@jswent
Copy link
Member

jswent commented Feb 20, 2026

@james-d-mitchell I think I can write a lua script that would work with the mutating function convention, I'll give it a shot when I have some time

james-d-mitchell and others added 2 commits February 20, 2026 19:10
Co-authored-by: Jake Swent <94636565+jswent@users.noreply.github.com>
@jswent
Copy link
Member

jswent commented Feb 21, 2026

@james-d-mitchell I think docs aren't building on this branch because of some issue with stale julia cache, just tested in another branch and it works fine. Can ignore that check.

@james-d-mitchell
Copy link
Member Author

So merge?

@james-d-mitchell james-d-mitchell merged commit 92201b0 into libsemigroups:main Feb 21, 2026
10 of 11 checks passed
@james-d-mitchell james-d-mitchell deleted the runner-doc branch February 21, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants