Merged
Conversation
|
@warmenhoven tks for PR, while this is good for CI builds, it doesn't necessary fix local (ppl will try to init all submodules by default with obvious failure). If we don't need other deps for libretro, they should be removed entirely (or at least fixed as per: #102) |
Contributor
Author
|
Yeah when I put up the PR I thought it was just the CI builder that was having problems, as it had been having a few networking or networking-adjacent problems recently. I agree, the submodules should probably just be removed entirely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://git.libretro.com/libretro/ecwolf/-/pipelines/46732