webOS: download assets/core info files/controller profiles on first run#18878
Open
cscd98 wants to merge 2 commits intolibretro:masterfrom
Open
webOS: download assets/core info files/controller profiles on first run#18878cscd98 wants to merge 2 commits intolibretro:masterfrom
cscd98 wants to merge 2 commits intolibretro:masterfrom
Conversation
0872f78 to
f642b67
Compare
Collaborator
|
I don't think we have any way of querying F-Droid as a platform, but they would undoubtedly appreciate this. If we applied it to the entire Android platform, our apks would be a lot smaller... |
Contributor
|
if you're on a roll, another common issue is on the first download of a core with requirement files like dolphin, people just don't get those files, and pay for it with a myriad of bogus bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guidelines
C89_BUILD=1Description
A relatively common issue with users who are unfamiliar with RetroArch is updating core info files/assets/controller profiles.
This enables these files to be automatically downloaded the very first time they open up RetroArch on webOS as they are not bundled. This is on purpose because application installs are given separate permissions and if they were indeed bundled it would stop a user from being able to update them via RetroArch menu.
It checks to see if 200MB (72.5MB for zip, 87.7MB unzipped) of space is available before download assets due to some older devices may lack the space to download plus decompress. It also checks for 250MB (51.7MB for zip, 180.1MB unzipped!) available space before automatically downloading the database. I have left some margin for error by rounding up to nearest 50MB but these could always be reduced.
Core profiles are absolutely necessary otherwise no cores are listed for download so they are always downloaded.
Has no affect on other platforms unless HAVE_UPDATE_ASSETS_FIRST_RUN is defined.
Includes work already done by @warmenhoven
Related Issues
Related Pull Requests
Reviewers