Use future::select_all for accept()#24
Merged
SudoDios merged 1 commit intolibrespeed:masterfrom May 13, 2025
Merged
Conversation
Collaborator
|
@lxb007981 Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of
accept()is to accept a connection from any available listener as soon as possible. In the previous implementation,select!waits on only the current listener and a timer. It forces the executor to wait 1ms if the accept() call on the current listener doesn't return within 1ms, and if no connection is immediately available on the current listener, there will be another minimum 1ms delay.This pr tries to improve it by using
future::select_allto wait on multiple listeners simultaneously and return the first one that completes.