fix(kad): confirm AddProvider sends via handler event and remove premature success#6196
Open
GarmashAlex wants to merge 2 commits intolibp2p:masterfrom
Open
fix(kad): confirm AddProvider sends via handler event and remove premature success#6196GarmashAlex wants to merge 2 commits intolibp2p:masterfrom
GarmashAlex wants to merge 2 commits intolibp2p:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add HandlerEvent::AddProviderSent and emit it when a one-way AddProvider request is successfully sent in the handler. Handle this event in the behaviour to progress the query for the sending peer. Remove the previous premature on_success on dispatch in
NetworkBehaviour::poll(). Also refactor Handler::poll() to remove a never-loop pattern flagged by clippy, keeping logic unchanged. This improves observability and correctness by acknowledging success only after the request is actually sent, while preserving existing error reporting.