fix: grow routing table trie towards node kad-id#2747
Draft
achingbrain wants to merge 1 commit intomainfrom
Draft
fix: grow routing table trie towards node kad-id#2747achingbrain wants to merge 1 commit intomainfrom
achingbrain wants to merge 1 commit intomainfrom
Conversation
Instead of having a balance trie, grow the routing table towards the current node's kad-id. This gives a better knowledge of the network as we get closer to our own kad-id. The previous behaviour can be replicated by setting `prefixLength` and `selfPrefixLength` to the same value.
Member
Author
|
Need to verify if this actually makes any difference. Because we have a prefix-trie, the trie only grows deeper if the kad-ids encountered share growing prefixes. There will be plenty of peers encountered that have xor-closer kad ids to the root node but will be omitted because the shared bytes are not in the prefix. That is, given the kad id: All of these are equally xor-distanced, but only the first would be included in the deeper section of the trie due to the shared bit being in the prefix: Using a prefix is probably good enough to ensure a reasonable starting point for a query for an arbitrary kad-id, but it may not help when trying to discover more of the kad-space local to the node's peer id. |
3 tasks
621b464 to
6059227
Compare
0f3ab9e to
d1ff510
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having a balance trie, grow the routing table towards the current node's kad-id.
This gives a better knowledge of the network as we get closer to our own kad-id.
The previous behaviour can be replicated by setting
prefixLengthandselfPrefixLengthto the same value.Change checklist