add_entry: Allow None for title, username, password#430
Open
spaetz wants to merge 2 commits intolibkeepass:masterfrom
Open
add_entry: Allow None for title, username, password#430spaetz wants to merge 2 commits intolibkeepass:masterfrom
spaetz wants to merge 2 commits intolibkeepass:masterfrom
Conversation
According to the docs, these parameters can also be passed None, in practice that failed. Add a test that passed in None parameters, which fails before the next commit that will allow these and passes after.
Our docs allow None, so make it so. None gets translated to an empty string in the XML. There is a corresponding test which tests this case. Fixes: libkeepass#416
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our docs allow None, so make it so. None gets translated to an empty string
in the XML for the "title", "username" and "password". There is a corresponding test which tests this case.
Fixes: #416