ci: add gcc/clang matrix with -Werror#353
Draft
abhinavagarwal07 wants to merge 1 commit into
Draft
Conversation
- Expand build job into gcc/clang matrix with fail-fast: false - Pass -Dwerror=true so compiler warnings fail the build - Pin all actions to Node 24-capable full SHAs (checkout v6.0.2, setup-python v6.2.0, upload-artifact v7.0.1) - Add least-privilege permissions, concurrency cancellation - Pin python-version to 3.12, pin runner to ubuntu-24.04 - Add explicit SSH setup with sshd start, hard-fail FUSE preflight - Add pytest --timeout=300, --maxfail=99, JUnit XML, test result artifacts per compiler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand the build job into a gcc/clang matrix with
fail-fast: falseso both compilers always report results. Pass-Dwerror=trueto meson so any compiler warning is a build failure.Includes all hygiene from the foundation PR: SHA-pinned Node 24-capable actions, least-privilege permissions, concurrency cancellation, pinned runner (
ubuntu-24.04) and Python (3.12), explicit SSH setup with sshd start, hard-fail FUSE preflight, pytest timeouts/maxfail/JUnit XML, and per-compiler test result artifacts.GCC and clang produce different warnings and catch different classes of issues. Running both with
-Werrorgives broader warning coverage than either compiler alone. Once merged, both rows should be required PR checks.