Skip to content

In electrum block_headers return count of headers returned. #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 2 commits into from
Mar 2, 2026
Merged

In electrum block_headers return count of headers returned. #650

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
938ed96
Comment.
evoskuil Feb 28, 2026
8229ae8
In electrum block_headers return count of headers returned.
evoskuil Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/protocols/protocol_electrum.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,15 +228,15 @@ void protocol_electrum::blockchain_block_headers(size_t starting,
if (multiplicity)
{
result["headers"] = std::move(headers);
result["count"] = uint64_t{ quantity };
result["count"] = headers.size();
result["max"] = maximum;
}
else
{
result["header"] = headers.front();
}

// There is a very slim change of inconsistency given an intervening reorg
// There is a very slim chance of inconsistency given an intervening reorg
// because of get_merkle_root_and_proof() use of height-based calculations.
// This is acceptable as it must be verified by caller in any case.
if (prove)
Expand Down
Loading