Skip to content

Fix bogus g++ dangling ref warnings. #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 2 commits into from
Jan 1, 2026
Merged

Fix bogus g++ dangling ref warnings. #698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa20793
Fix bogus g++ dangling ref warnings.
evoskuil Jan 1, 2026
da2704a
Comments.
evoskuil Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions include/bitcoin/network/net/acceptor.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ class BCT_API acceptor

DELETE_COPY_MOVE(acceptor);

// Construct.
// ------------------------------------------------------------------------
/// Construct.
/// -----------------------------------------------------------------------

/// Construct an instance.
acceptor(const logger& log, asio::strand& strand, asio::io_context& service,
Expand All @@ -53,8 +53,8 @@ class BCT_API acceptor
/// Asserts/logs stopped.
virtual ~acceptor() NOEXCEPT;

// Start/stop.
// ------------------------------------------------------------------------
/// Start/stop.
/// -----------------------------------------------------------------------
/// Starts return operation_failed if not stopped.

/// Start the listener on the specified ip address and port (call once).
Expand All @@ -63,14 +63,14 @@ class BCT_API acceptor
/// Cancel work (idempotent), handler signals completion.
virtual void stop() NOEXCEPT;

// Properties.
// ------------------------------------------------------------------------
/// Properties.
/// -----------------------------------------------------------------------

/// The local endpoint to which this acceptor is bound (requires strand).
virtual config::authority local() const NOEXCEPT;

// Methods.
// ------------------------------------------------------------------------
/// Methods.
/// -----------------------------------------------------------------------
/// Subsequent accepts may only be attempted following handler invocation.
/// The socket parameter is nullptr unless success is returned.

Expand Down
12 changes: 6 additions & 6 deletions include/bitcoin/network/net/connector.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ class BCT_API connector

DELETE_COPY_MOVE(connector);

// Construct.
// ------------------------------------------------------------------------
/// Construct.
/// -----------------------------------------------------------------------

/// Construct an instance.
connector(const logger& log, asio::strand& strand,
Expand All @@ -57,14 +57,14 @@ class BCT_API connector
/// Asserts/logs stopped.
virtual ~connector() NOEXCEPT;

// Stop (no start).
// ------------------------------------------------------------------------
/// Stop (no start).
/// -----------------------------------------------------------------------

/// Cancel work (idempotent), handler signals completion.
virtual void stop() NOEXCEPT;

// Methods.
// ------------------------------------------------------------------------
/// Methods.
/// -----------------------------------------------------------------------
/// Subsequent accepts may only be attempted following handler invocation.
/// The socket parameter is nullptr unless success is returned.

Expand Down
9 changes: 3 additions & 6 deletions src/error.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,8 +395,7 @@ code asio_to_error_code(const boost_code& ec) NOEXCEPT
// includes json codes
code http_to_error_code(const boost_code& ec) NOEXCEPT
{
static const auto& category = boost::beast::http::
make_error_code(http_error_t::end_of_stream).category();
static boost::beast::http::detail::http_error_category category{};

if (!ec)
return error::success;
Expand Down Expand Up @@ -439,8 +438,7 @@ code http_to_error_code(const boost_code& ec) NOEXCEPT
// includes json codes
code ws_to_error_code(const boost_code& ec) NOEXCEPT
{
static const auto& category = boost::beast::websocket::
make_error_code(ws_error_t::closed).category();
static boost::beast::websocket::detail::error_codes category{};

if (!ec)
return error::success;
Expand Down Expand Up @@ -487,8 +485,7 @@ code ws_to_error_code(const boost_code& ec) NOEXCEPT

code json_to_error_code(const boost_code& ec) NOEXCEPT
{
static const auto& category = boost::json::
make_error_code(json_error_t::syntax).category();
static boost::json::detail::error_code_category_t category{};

if (!ec)
return error::success;
Expand Down
Loading