Kokkos build and numerics support #4451
Conversation
a5b5eda to
e9a0948
Compare
e9a0948 to
63d0098
Compare
roystgnr
left a comment
There was a problem hiding this comment.
We're definitely getting there. I'd say the only thing that really ought to be fixed now is the error macro forwarding direction and (unless there's a good reason not to that I'm missing) the function redundancies.
roystgnr
left a comment
There was a problem hiding this comment.
Make system and error handling look good to go now!
We've still got more duplication than we want in the math operators, though; not all of the "an operator which just shims a custom-named function that doesn't need to exist separately" cases are gone, and there's some more subtle "N operators shim a custom-named function" cases than could be turned into "N-1 operators call the one of them that now has the implementation in it".
| CXXFLAGS="$CXXFLAGS $KOKKOS_CXXFLAGS" | ||
| LDFLAGS="$LDFLAGS $KOKKOS_LDFLAGS" | ||
| LIBS="$LIBS $KOKKOS_LIBS" | ||
| AC_LANG_PUSH([C++]) |
There was a problem hiding this comment.
Split all commits like this in two in the future - the stuff we actually change in the first, and the stuff that bootstrap (or autoreconf, however you do it) changes in the second.
This PR adds the first upstreamable slice of libMesh Kokkos support: build-system integration for .K translation units plus
standalone Kokkos numerics oracle tests.
The scope is intentionally limited to: