Add generation of a paving of polygons+tris+quad for the polygon option#4357
Open
GiudGiud wants to merge 3 commits intolibMesh:develfrom
Open
Add generation of a paving of polygons+tris+quad for the polygon option#4357GiudGiud wants to merge 3 commits intolibMesh:develfrom
GiudGiud wants to merge 3 commits intolibMesh:develfrom
Conversation
GiudGiud
force-pushed
the
PR_hex_tiling
branch
3 times, most recently
from
1cbd20f to
a889195
Compare
GiudGiud
commented
Dec 21, 2025
src/mesh/mesh_generation.C
Outdated
| node_list.push_back(node2); | ||
| } | ||
|
|
||
| new_elem = std::make_unique<Tri3>(); |
Contributor
Author
There was a problem hiding this comment.
this could also be a C0Polygon that is like a triangle. What is your preference?
Same for the quad on the sides.
Contributor
Author
There was a problem hiding this comment.
That's probably what I would prefer actually. Means less subdomains for exodus later on
Member
There was a problem hiding this comment.
Let's leave the mixed code commented out? In the short run doing all-polygon makes sense, but triangles+quads are a bit more efficient, and I'm hoping to get to multi-block subdomain support in Exodus soon.
GiudGiud
force-pushed
the
PR_hex_tiling
branch
from
a889195 to
72c23c5
Compare
GiudGiud
changed the title
roystgnr
approved these changes
Dec 22, 2025
having users separate blocks manually
GiudGiud
force-pushed
the
PR_hex_tiling
branch
from
2e42890 to
4a805f6
Compare
Contributor
Author
|
This looks like it could be merged? @roystgnr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bounding boxes of sidesets are correct. Still possible to be missing some sides but unlikely