hp-Adaptivity: Smoothness percentage control flexibility#4228
Open
skvarjun wants to merge 2 commits intolibMesh:develfrom
Open
hp-Adaptivity: Smoothness percentage control flexibility#4228skvarjun wants to merge 2 commits intolibMesh:develfrom
skvarjun wants to merge 2 commits intolibMesh:develfrom
Conversation
5fc57d1 to
f97bb2a
Compare
roystgnr
requested changes
Aug 15, 2025
| * refinement type. | ||
| */ | ||
| virtual void select_refinement (System & system) = 0; | ||
| virtual void select_refinement (System & system, Real smoothness_threshold = 0.9) = 0; |
Member
There was a problem hiding this comment.
Can we move smoothness_threshold into a member variable of the subclass with an accessor? It's only appropriate in the base class if it's going to be used by every possible subclass, and there are at least some selection possibilities that don't rely on a posteriori smoothness testing.
Contributor
Author
There was a problem hiding this comment.
Yes, I agree with this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User can control the percentage of smoothness values above which p-refinement is favored in hp-adaptivity. For instance, default value is set as 0.9, means p refining favored on an element only if local smoothness is above 90% when compared to the reported smoothness across all other elements.
Important change is that an option argument
Real smoothness_threshold = 0.9is added to base class ofselect_refinement().