Implement Girudo Integration for Spellbot #2138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tegration, and introduce a new spell bot integration named Girudo.
lexicalunit
reviewed
Jan 6, 2026
lexicalunit
reviewed
Jan 6, 2026
lexicalunit
reviewed
Jan 6, 2026
lexicalunit
reviewed
Jan 6, 2026
lexicalunit
reviewed
Jan 6, 2026
…-ayaz/spellbot-gd into feature/girudo-integration
…tegration - Add None checks and URL validation in girudo.py to ensure type safety. - Improve type annotations in test_girudo.py and mocks/girudo.py. - Align # type: ignore comments in tests to satisfy pyright. - Fix ruff linting errors and format code. - Create tests/integration/__init__.py to fix implicit namespace package warning. - Sort exports in tests/mocks/__init__.py.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2138 +/- ##
==========================================
- Coverage 95.56% 95.10% -0.46%
==========================================
Files 198 202 +4
Lines 10330 10981 +651
Branches 430 470 +40
==========================================
+ Hits 9872 10444 +572
- Misses 407 468 +61
- Partials 51 69 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lexicalunit
reviewed
Jan 6, 2026
lexicalunit
reviewed
Jan 6, 2026
lexicalunit
reviewed
Jan 6, 2026
…TTPClient` to inherit from `httpx.AsyncClient`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have implemented the Girudo integration for Spellbot.
This includes the implementation of a Girudo service for LFG action. This enables the user to select Girudo as a platform for the "lfg" command and can play with other users in their Discord servers.
We are using multiple environment variables, which are listed as follows:
Note: We have reviewed our test coverage, and it satisfies the threshold that has been mentioned.