wfe/ra/va/pa: Add support for draft-ietf-acme-dns-persist-00#8660
wfe/ra/va/pa: Add support for draft-ietf-acme-dns-persist-00#8660beautifulentropy wants to merge 5 commits intomainfrom
Conversation
8d96489 to
6e93913
Compare
|
@beautifulentropy, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
|
@beautifulentropy, this PR adds one or more new feature flags: DNSPersist01Enabled. As such, this PR must be accompanied by a review of the Let's Encrypt CP/CPS to ensure that our behavior both before and after this flag is flipped is compliant with that document. Please conduct such a review, then add your findings to the PR description in a paragraph beginning with "CPS Compliance Review:". |
6e93913 to
6adb2e9
Compare
aarongable
left a comment
There was a problem hiding this comment.
A few comments, mostly small. One big comment on the structure of validateDNSPersist01 itself, so I haven't done a detailed review of its corresponding unit tests yet. Will do that review when they're broken out into helper-level tests.
Warning
This PR depends on: eggsampler/acme#31. Once it has been merged we'll need to update go.mod and re-vendor.
Implement the dns-persist-01 ACME challenge type as specified in draft-ietf-acme-dns-persist-00. This challenge proves domain control via a persistent DNS TXT record at
_validation-persist.<domain>containing the CA's issuer domain name and the subscriber's account URI.The following optional features are deliberately not implemented:
Fixes #8527