test: add health check for bvitess#8658
Draft
jsha wants to merge 4 commits intovschemas-and-vindexesfrom
Draft
Conversation
aarongable
reviewed
Mar 6, 2026
docker-compose.yml
Outdated
Comment on lines
+170
to
+174
| interval: 2s | ||
| timeout: 30s | ||
| retries: 3 | ||
| start_period: 10s | ||
| start_interval: 2s |
Contributor
There was a problem hiding this comment.
By my reading of these docs, I think having interval and start_interval set to the same value is redundant. Since you have start_period set to 10 seconds, no failures during that whole first 10 seconds will cause the container to actually be marked unhealthy, so we could have the start_interval be much smaller (like 200ms) so it's quicker to respond once the container actually does come up.
Unless that just makes the "You have an error in your SQL syntax" logging super spammy?
This replaces the health check inside `test/entrypoint.sh`. Advantage: if bvitess exits outright during health checking, `docker compose` can report that more clearly than `test/entrypoint.sh` can, and can also terminte the run of the `boulder` container early, rather than waiting for the health check to timeout. We can apply the same transformation to the other health checks if we like this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the health check inside
test/entrypoint.sh. Advantage: if bvitess exits outright during health checking,docker composecan report that more clearly thantest/entrypoint.shcan, and can also terminte the run of thebouldercontainer early, rather than waiting for the health check to timeout.We can apply the same transformation to the other health checks if we like this one.
Warning
This PR is based on top of #8634. Do not merge before that one.