Skip to content

web: No longer escape HTML characters in SendError #8533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
beautifulentropy merged 2 commits into from
Dec 20, 2025
Merged

web: No longer escape HTML characters in SendError #8533

beautifulentropy merged 2 commits into from
Dec 20, 2025

Conversation

@beautifulentropy
Copy link
Member

@beautifulentropy beautifulentropy commented Dec 19, 2025

No description provided.

@beautifulentropy beautifulentropy marked this pull request as ready for review December 19, 2025 19:13
@beautifulentropy beautifulentropy requested a review from a team as a code owner December 19, 2025 19:13
@beautifulentropy beautifulentropy changed the title web: No longer escape HTML character in SendError web: No longer escape HTML characters in SendError Dec 19, 2025
jprenken
jprenken previously approved these changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@jprenken jprenken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: For completeness, it might be nice to add a unit test for whether other, special-er characters are still escaped.

@jprenken jprenken requested a review from aarongable December 19, 2025 21:11
@beautifulentropy
Copy link
Member Author

beautifulentropy commented Dec 19, 2025 •
edited
Loading

Nit: For completeness, it might be nice to add a unit test for whether other, special-er characters are still escaped.

I'm fairly sure I'm testing this in: TestSendErrorDoesNotEscapeHTML. Let me know what you'd like to see though.

@beautifulentropy beautifulentropy merged commit 5cd6873 into main Dec 20, 2025
17 checks passed
@beautifulentropy beautifulentropy deleted the senderror-no-escape-html branch December 20, 2025 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aarongable aarongable aarongable approved these changes

@jprenken jprenken jprenken approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@beautifulentropy @aarongable @jprenken