Delete sa.GetMaxExpiration and sa.GetRevokedCerts#8401
Merged
aarongable merged 4 commits intomainfrom Oct 16, 2025
Merged
Conversation
aarongable
force-pushed
the
rm-sa-methods
branch
from
d554f0a to
658ccdf
Compare
jsha
previously approved these changes
Sep 25, 2025
Contributor
jsha
left a comment
jsha
left a comment
There was a problem hiding this comment.
Approve modulo need to wait for deploy.
jprenken
previously approved these changes
Oct 1, 2025
jsha
previously approved these changes
Oct 1, 2025
Contributor
Author
|
The merge conflict will be resolved when #8428 lands, so I'm just going to wait on that. |
Contributor
Author
|
Also waiting to merge until after next week's tag has been cut and fully deployed (likely Oct 9), since this week's tag had to be rolled back. |
Contributor
Author
|
Merge conflict and deploy blocker both resolved; requesting re-review. |
jsha
approved these changes
Oct 14, 2025
Contributor
jsha
left a comment
jsha
left a comment
There was a problem hiding this comment.
Reminder to edit the Warning out of the description.
jprenken
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two SA methods were used only by the crl-updater's temporal (notAfter-based) sharding code. We now exclusively use explicit (CRLDP-based) sharding, and these methods have no callers.
Fixes #8399
Part of #8322
Warning
Do not merge before #8400 has been successfully deployed, likely Oct 9