feature(controls): Make Durations customizable#1679
Open
dkuaf wants to merge 3 commits intolepoco:mainfrom
Open
feature(controls): Make Durations customizable#1679dkuaf wants to merge 3 commits intolepoco:mainfrom
dkuaf wants to merge 3 commits intolepoco:mainfrom
Conversation
github-actions
bot
added
controls
dkuaf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Durations on Animations are freezable, this pull request provides a way to make Durations customizable.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Durations on Animation has hard coded values for all controls
Issue Number: #1586
fixes #1586
What is the new behavior?
Durations can be of three types: SlowDuration, NormalDuration and FastDuration. These can all be set when merging ControlsDictionary. Defaults to previous hardcoded values (no breaking change)
<ui:ControlsDictionary SlowDuration="0:0:0.0" NormalDuration="0:0:0.0" FastDuration="0:0:0.0" />Other information