-
Notifications
You must be signed in to change notification settings - Fork 9
Add command that let's Tyrant pick a user's role #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I am using Loguru in this PR, so it will have to wait for #17. |
|
I'll rebase and mark this as reviewable again when I get home |
This command can be used when somebody doesn't know what role they want to pick.
|
This now depends on #19, but feel free to mark this as ready and merge it when that is merged as it is tested and has been rebased on top of that. |
tyrant/cogs/pick_team.py
Outdated
| @commands.command(aliases=("team",)) | ||
| async def pick(self, ctx: Context): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These command names and alises feel wrong. .team or .pick feels like commands that you would use if the user used them to pick a team, not a command that would randomly assign a team for you.
I think we should find a more descriptive name for this. something like .random_team feels like an obvious choice, and .enlist and .enroll feel like fun tyrant-themed aliases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want me to rename the cog and file with these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure, the cog and the file can sort of be defended with the rationale that this bot is the tyrant and the tyrant is the one picking the role. But I don't think we can defend the commands, because the users are the ones running those commands.
I'll leave it up to you.
I decided to take a break from other things to make a little silly command.
This command can be used when somebody doesn't know what role they want to pick.
It hashes a user's name, discriminator and avatar. Together these can be considered a user's "personality" (fetching messages would be too costly).
Even if someone sets their avatar and name to be the same as another user the result will not be the same because of the discriminator (I also believe that the asset key is arbitrary and not a hash of the image so that may also differ).