Skip to content

Conversation

@Bluenix2
Copy link

@Bluenix2 Bluenix2 commented Oct 7, 2021

I decided to take a break from other things to make a little silly command.

This command can be used when somebody doesn't know what role they want to pick.

It hashes a user's name, discriminator and avatar. Together these can be considered a user's "personality" (fetching messages would be too costly).

Even if someone sets their avatar and name to be the same as another user the result will not be the same because of the discriminator (I also believe that the asset key is arbitrary and not a hash of the image so that may also differ).

@Bluenix2 Bluenix2 marked this pull request as draft October 12, 2021 20:21
@Bluenix2
Copy link
Author

I am using Loguru in this PR, so it will have to wait for #17.

@lemonsaurus
Copy link
Owner

@Bluenix2 #17 has now been merged.

@Bluenix2
Copy link
Author

I'll rebase and mark this as reviewable again when I get home

This command can be used when somebody doesn't know what role they want to pick.
@Bluenix2
Copy link
Author

This now depends on #19, but feel free to mark this as ready and merge it when that is merged as it is tested and has been rebased on top of that.

@Bluenix2 Bluenix2 marked this pull request as ready for review October 22, 2021 08:02
Comment on lines 16 to 17
@commands.command(aliases=("team",))
async def pick(self, ctx: Context):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These command names and alises feel wrong. .team or .pick feels like commands that you would use if the user used them to pick a team, not a command that would randomly assign a team for you.

I think we should find a more descriptive name for this. something like .random_team feels like an obvious choice, and .enlist and .enroll feel like fun tyrant-themed aliases.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to rename the cog and file with these changes?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, the cog and the file can sort of be defended with the rationale that this bot is the tyrant and the tyrant is the one picking the role. But I don't think we can defend the commands, because the users are the ones running those commands.

I'll leave it up to you.

@Bluenix2 Bluenix2 requested a review from lemonsaurus February 27, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants