Improved XMLNode::~XMLNode perfomance#1044
Open
IMBIGFISH4 wants to merge 1 commit intoleethomason:masterfrom
Open
Improved XMLNode::~XMLNode perfomance#1044IMBIGFISH4 wants to merge 1 commit intoleethomason:masterfrom
IMBIGFISH4 wants to merge 1 commit intoleethomason:masterfrom
Conversation
XMLNode::~XMLNode uses interface method DeleteChildren(), which iteratively removes the first child until the list is empty. Each single removal performs additional checks and keeps _firstChild and _lastChild links in a consistent state. This leads to a performance penalty. The proposed patch solves this problem by iterating the list of the children and directly destroying them without keeping links in a consistent state. The performance boost we gained on xmltest is: - 3% for my laptop (x86_64) - 9% for bananapi f3 board (riscv64)
Owner
|
I don't see how this does anything - all the nodes still have to be deleted. Something to do with the linked list? Open until I can sort it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XMLNode::~XMLNode uses interface method DeleteChildren(), which iteratively removes the first child until the list is empty. Each single removal performs additional checks and keeps _firstChild and _lastChild links in a consistent state. This leads to a performance penalty.
The proposed patch solves this problem by iterating the list of the children and directly destroying them without keeping links in a consistent state.
The performance boost we gained on xmltest is: